geruh commented on code in PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#discussion_r1606272619
##########
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java:
##########
@@ -234,8 +259,26 @@ static void setTableInputInformation(
Optional.ofNullable(properties.get(GLUE_DESCRIPTION_KEY))
.ifPresent(tableInputBuilder::description);
+ List<Column> columns = toColumns(metadata);
+ if (existingTable != null) {
+ List<Column> existingColumns =
existingTable.storageDescriptor().columns();
+ Map<String, Column> existingColumnMap =
Review Comment:
What do you think about making this a map of column name to comment here.
Since we aren't using any additional information from the existing comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
