MehulBatra commented on code in PR #711:
URL: https://github.com/apache/iceberg-python/pull/711#discussion_r1608874056
##########
tests/catalog/integration_test_glue.py:
##########
@@ -564,3 +564,13 @@ def test_table_exists(test_catalog: Catalog,
table_schema_nested: Schema, table_
test_catalog.create_namespace(database_name)
test_catalog.create_table((database_name, table_name), table_schema_nested)
assert test_catalog.table_exists((database_name, table_name)) is True
+
+
+def test_register_table(test_catalog: Catalog, metadata_location: str,
table_name: str, database_name: str) -> None:
Review Comment:
It clearly improves our approach and provides a better framework for the
integration test. I will implement the suggested changes and raise the PR.
Thank you so much, Honah, for this fantastic suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
