liurenjie1024 commented on code in PR #374:
URL: https://github.com/apache/iceberg-rust/pull/374#discussion_r1613216338
##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -472,6 +474,19 @@ pub(super) mod _serde {
pub default_sort_order_id: Option<i64>,
}
+ // Skip serializing current snapshot if snapshot is none
+ // and `legacy-current-snapshot-id` is not enabled.
+ fn skip_current_snapshot(current_snapshot_id: &Option<i64>) -> bool {
Review Comment:
I'm hesitating to control this behavior using environment, maybe we should
pass options to reader or writer of table metadata?
##########
crates/catalog/rest/testdata/update_table_response.json:
##########
@@ -31,7 +31,6 @@
"write.summary.partition-limit": "100",
"write.parquet.compression-codec": "zstd"
},
- "current-snapshot-id": -1,
Review Comment:
Maybe we should add another test case rather than simply removing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
