nastra commented on code in PR #10411:
URL: https://github.com/apache/iceberg/pull/10411#discussion_r1624294761
##########
1.5.2/docs/configuration.md:
##########
@@ -133,7 +133,7 @@ Iceberg catalogs support using catalog properties to
configure catalog behaviors
| clients | 2 | client pool size
|
| cache-enabled | true | Whether to cache
catalog entries |
| cache.expiration-interval-ms | 30000 | How long catalog
entries are locally cached, in milliseconds; 0 disables caching, negative
values disable expiration |
-| metrics-reporter-impl | org.apache.iceberg.metrics.LoggingMetricsReporter |
Custom `MetricsReporter` implementation to use in a catalog. See the [Metrics
reporting](../metrics-reporting.md) section for additional details |
+| metrics-reporter-impl | org.apache.iceberg.metrics.LoggingMetricsReporter |
Custom `MetricsReporter` implementation to use in a catalog. See the [Metrics
reporting](metrics-reporting.md) section for additional details |
Review Comment:
I'm surprised that this is an issue in the 1.5.2 docs given that ##9965
fixed this before 1.5.2 went out. @amogh-jahagirdar I'm guessing docs-wise for
https://github.com/apache/iceberg/pull/10282 you were probably just using
whatever existed for the 1.5.1 docs? At that time we most likely just haven't
had backports for the link fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
