flyrain commented on code in PR #10434:
URL: https://github.com/apache/iceberg/pull/10434#discussion_r1625196927
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2603,30 +2603,29 @@ components:
properties:
type:
type: "string"
+ enum:
+ - "assert-create"
+ - "assert-table-uuid"
+ - "assert-ref-snapshot-id"
+ - "assert-last-assigned-field-id"
+ - "assert-current-schema-id"
+ - "assert-last-assigned-partition-id"
+ - "assert-default-spec-id"
+ - "assert-default-sort-order-id"
Review Comment:
Minor: it is not a big deal, but it would be more readable if we move the
`discriminator` under the properties section. Spec reader will understand
better about the mapping between the `type` property name and correspondent
schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
