ajantha-bhat commented on code in PR #10446:
URL: https://github.com/apache/iceberg/pull/10446#discussion_r1629502264
##########
core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java:
##########
@@ -275,14 +275,17 @@ private boolean matchesPredicate(ManifestFile manifest) {
return predicate == null || predicate.test(manifest);
}
- private void validateDeletedManifests(Set<ManifestFile> currentManifests) {
+ private void validateDeletedManifests(
+ Set<ManifestFile> currentManifests, long currentSnapshotID) {
// directly deleted manifests must be still present in the current snapshot
deletedManifests.stream()
.filter(manifest -> !currentManifests.contains(manifest))
.findAny()
.ifPresent(
manifest -> {
- throw new ValidationException("Manifest is missing: %s",
manifest.path());
+ throw new ValidationException(
+ "Deleted manifest %s could not be found in the current
snapshot %d",
Review Comment:
"current" is the "latest". So, I feel it is ok as we are printing snapshot
id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
