Fokko commented on code in PR #10090:
URL: https://github.com/apache/iceberg/pull/10090#discussion_r1631916500
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetBloomRowGroupFilter.java:
##########
@@ -290,7 +299,7 @@ private <T> boolean shouldRead(
hashValue = bloom.hash(((Number) value).intValue());
return bloom.findHash(hashValue);
default:
- return ROWS_MIGHT_MATCH;
+ return true;
Review Comment:
I think it is more readable to keep the constants:
```suggestion
return ROWS_MIGHT_MATCH;
```
A few more occurrences below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
