bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632299563
##########
kafka-connect/kafka-connect-events/src/test/java/org/apache/iceberg/connect/events/EventTestUtil.java:
##########
@@ -45,7 +45,7 @@ private EventTestUtil() {}
new Schema(ImmutableList.of(Types.NestedField.required(1, "id",
Types.LongType.get())));
static final PartitionSpec SPEC =
- PartitionSpec.builderFor(SCHEMA).identity("id").withSpecId(1).build();
+ PartitionSpec.builderFor(SCHEMA).identity("id").withSpecId(0).build();
Review Comment:
Thanks I changed this.
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/CatalogUtils.java:
##########
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.connect;
+
+import java.io.IOException;
+import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.List;
+import org.apache.iceberg.CatalogUtil;
+import org.apache.iceberg.catalog.Catalog;
+import org.apache.iceberg.common.DynClasses;
+import org.apache.iceberg.common.DynConstructors;
+import org.apache.iceberg.common.DynMethods;
+import org.apache.iceberg.common.DynMethods.BoundMethod;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+class CatalogUtils {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(CatalogUtils.class.getName());
+ private static final List<String> HADOOP_CONF_FILES =
+ ImmutableList.of("core-site.xml", "hdfs-site.xml", "hive-site.xml");
+
+ static Catalog loadCatalog(IcebergSinkConfig config) {
+ return CatalogUtil.buildIcebergCatalog(
+ config.catalogName(), config.catalogProps(), loadHadoopConfig(config));
+ }
+
+ // use reflection here to avoid requiring Hadoop as a dependency
+ private static Object loadHadoopConfig(IcebergSinkConfig config) {
Review Comment:
I agree, that could be useful, though it may require some discussion to get
right, so I'd rather start with this here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
