sdd commented on code in PR #373:
URL: https://github.com/apache/iceberg-rust/pull/373#discussion_r1639361290
##########
crates/iceberg/src/scan.rs:
##########
@@ -302,13 +262,147 @@ impl TableScan {
arrow_reader_builder.build().read(self.plan_files().await?)
}
+}
+
+#[derive(Debug)]
+struct ConcurrentFileScanStreamContext {
Review Comment:
I've refactored these into a single context. Now that we are using the
`ExpressionEvaluator` though, I ended up creating another context object that
gets passed to the manifest file closure. This was just a tuple before but
clippy complained when I added one more item to it :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
