MehulBatra commented on code in PR #790:
URL: https://github.com/apache/iceberg-python/pull/790#discussion_r1642734352
##########
pyiceberg/io/pyarrow.py:
##########
@@ -912,6 +916,9 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return TimestamptzType()
elif primitive.tz is None:
return TimestampType()
+ if primitive.unit == "ns":
+ if primitive.tz == "UTC":
+ return TimestamptzType()
Review Comment:
Yes @HonahX you got it right arrow is reading the ORC timestamp unit as `ns`
that's why I added a schema conversion at the primitive types even after being
aware that we will be supporting nanoseconds in the coming version3, but I feel
your suggestion makes sense till the time we start supporting version3
altogether.
I will try to incorporate the changes to read `ns` as `us`.
@Fokko what do you think are we good with this, for the time being?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
