nastra commented on code in PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#discussion_r1644271939
##########
baseline.gradle:
##########
@@ -73,39 +73,57 @@ subprojects {
options.errorprone.errorproneArgs.addAll (
// error-prone is slow, don't run on tests/generated-src/generated
'-XepExcludedPaths:.*/(test|generated-src|generated)/.*',
- // specific to Palantir
- '-Xep:ConsistentLoggerName:OFF', // Uses name `log` but we use name
`LOG`
- '-Xep:FinalClass:OFF',
- '-Xep:PreferSafeLoggingPreconditions:OFF',
- '-Xep:PreferSafeLoggableExceptions:OFF',
- '-Xep:Slf4jLogsafeArgs:OFF',
- '-Xep:RawTypes:OFF',
- // enforce logging conventions
- '-Xep:LoggerEnclosingClass:ERROR',
- '-Xep:PreferStaticLoggers:ERROR',
- '-Xep:Slf4jThrowable:ERROR',
+ '-Xep:AnnotateFormatMethod:ERROR',
Review Comment:
it would be good to structure this so that it's clearly visible what changed
here. Atm it's difficult to tell what was added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
