chinmay-bhat commented on code in PR #822:
URL: https://github.com/apache/iceberg-python/pull/822#discussion_r1644663032
##########
pyiceberg/table/__init__.py:
##########
@@ -1978,6 +2013,21 @@ def create_tag(self, snapshot_id: int, tag_name: str,
max_ref_age_ms: Optional[i
self._requirements += requirement
return self
+ def remove_tag(self, tag_name: str) -> ManageSnapshots:
+ """
+ Remove a tag.
+
+ Args:
+ tag_name (str): name of tag to remove
+
+ Returns:
+ This for method chaining
+ """
+ update, requirement =
self._transaction._remove_ref_snapshot(ref_name=tag_name)
Review Comment:
add `self._commit_if_ref_updates_exist()` once it's merged into main from
#758 .
##########
pyiceberg/table/__init__.py:
##########
@@ -2010,6 +2060,20 @@ def create_branch(
self._requirements += requirement
return self
+ def remove_branch(self, branch_name: str) -> ManageSnapshots:
+ """
+ Remove a branch.
+
+ Args:
+ branch_name (str): name of branch to remove
+ Returns:
+ This for method chaining
+ """
+ update, requirement =
self._transaction._remove_ref_snapshot(ref_name=branch_name)
Review Comment:
add `self._commit_if_ref_updates_exist()` once it's merged into main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
