pvary commented on code in PR #10526:
URL: https://github.com/apache/iceberg/pull/10526#discussion_r1647508483
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/SimpleDataUtil.java:
##########
@@ -82,6 +83,13 @@ private SimpleDataUtil() {}
Types.NestedField.optional(1, "id", Types.IntegerType.get()),
Types.NestedField.optional(2, "data", Types.StringType.get()));
+ public static final Schema SCHEMA_PRI =
Review Comment:
could we use a more descriptive name, like `SCHEMA_WITH_PRIMARY_KEY`?
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##########
@@ -96,7 +96,7 @@ class IcebergFilesCommitter extends
AbstractStreamOperator<Void>
// The completed files cache for current checkpoint. Once the snapshot
barrier received, it will
// be flushed to the 'dataFilesPerCheckpoint'.
- private final List<WriteResult> writeResultsOfCurrentCkpt =
Lists.newArrayList();
+ private final Map<Long, List<WriteResult>> writeResultsOfCurrentCkpt =
Maps.newHashMap();
Review Comment:
nit: maybe a better name for this, like `writeResultsSinceLastSnapshot`?
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/SimpleDataUtil.java:
##########
@@ -310,6 +318,9 @@ public static void assertTableRecords(Table table,
List<Record> expected, String
StructLikeSet actualSet = StructLikeSet.create(type);
for (Record record : iterable) {
+ if (!table.schema().identifierFieldNames().isEmpty()) {
+ Assert.assertFalse("Should not have the identical record",
actualSet.contains(record));
+ }
Review Comment:
nit: We usually add a new line after the blocks (the most annoying review
comment which I also get all the time 😄)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
