jbonofre commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1661040951
##########
baseline.gradle:
##########
@@ -45,7 +45,10 @@ subprojects {
apply plugin: 'com.palantir.baseline-reproducibility'
apply plugin: 'com.palantir.baseline-exact-dependencies'
apply plugin: 'com.palantir.baseline-release-compatibility'
- apply plugin: 'com.diffplug.spotless'
+ // We need to update Google Java Format to 1.17.0+ to run spotless on JDK 8,
but that requires dropping support for JDK 8.
+ if (JavaVersion.current() != JavaVersion.VERSION_21) {
+ apply plugin: 'com.diffplug.spotless'
Review Comment:
I think the comment is not accurate: we need to update Google Java Format to
1.17.0+ to run spotless on JDK21, but it breaks JDK8.
I'm more in favor of jumping to JDK21 with spotless/GJF 1.17.0+, as soon as
we don't have any module requiring JDK8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
