aokolnychyi commented on code in PR #10288: URL: https://github.com/apache/iceberg/pull/10288#discussion_r1663365052
########## api/src/main/java/org/apache/iceberg/actions/AnalyzeTable.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import org.apache.iceberg.StatisticsFile; + +/** An action that collects statistics of an Iceberg table and writes to Puffin files. */ +public interface AnalyzeTable extends Action<AnalyzeTable, AnalyzeTable.Result> { + /** + * The set of columns to be analyzed + * + * @param columns a set of column names to be analyzed + * @return this for method chaining + */ + AnalyzeTable columns(String... columns); + + /** + * Id of the snapshot for which stats need to be collected + * + * @param snapshotId long id of the snapshot for which stats need to be collected + * @return this for method chaining + */ + AnalyzeTable snapshot(long snapshotId); + + /** The action result that contains summaries of the Analysis. */ + interface Result { + + /** Returns statistics file. */ + StatisticsFile statisticFile(); Review Comment: I think we are missing `s` here: `statisticFile()` -> `statisticsFile();` ########## api/src/main/java/org/apache/iceberg/actions/AnalyzeTable.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import org.apache.iceberg.StatisticsFile; + +/** An action that collects statistics of an Iceberg table and writes to Puffin files. */ +public interface AnalyzeTable extends Action<AnalyzeTable, AnalyzeTable.Result> { + /** + * The set of columns to be analyzed + * + * @param columns a set of column names to be analyzed + * @return this for method chaining + */ + AnalyzeTable columns(String... columns); + + /** + * Id of the snapshot for which stats need to be collected + * + * @param snapshotId long id of the snapshot for which stats need to be collected + * @return this for method chaining + */ + AnalyzeTable snapshot(long snapshotId); + + /** The action result that contains summaries of the Analysis. */ + interface Result { + + /** Returns statistics file. */ + StatisticsFile statisticFile(); Review Comment: I think we are missing `s` here: `statisticFile()` -> `statisticsFile()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
