kevinjqliu commented on code in PR #886:
URL: https://github.com/apache/iceberg-python/pull/886#discussion_r1664577534
##########
tests/catalog/test_sql.py:
##########
@@ -168,6 +168,39 @@ def test_creation_with_unsupported_uri(catalog_name: str)
-> None:
SqlCatalog(catalog_name, uri="unsupported:xxx")
+@pytest.mark.parametrize(
+ "echo_param, expected_echo_value",
+ [(None, strtobool(DEFAULT_ECHO_VALUE)), ("debug", "debug"), ("true",
True), ("false", False)],
Review Comment:
my preference is to use for-loop instead of parameterized tests.
> for-loops are often hiding on which input the test is failing
I've seen patterns like
```
assert catalog.engine._echo == expected_echo_value, (
f"Assertion failed: expected echo value {expected_echo_value}, "
f"but got {catalog.engine._echo}. For echo_param={echo_param}"
)
```
which makes it easier to figure out which variable inside the for-loop is
causing the assertion error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
