nastra commented on code in PR #10632:
URL: https://github.com/apache/iceberg/pull/10632#discussion_r1666447189
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/enumerator/TestContinuousSplitPlannerImplStartStrategy.java:
##########
@@ -18,42 +18,41 @@
*/
package org.apache.iceberg.flink.source.enumerator;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import java.io.IOException;
+import java.nio.file.Path;
import java.util.List;
import org.apache.iceberg.FileFormat;
import org.apache.iceberg.Snapshot;
import org.apache.iceberg.data.GenericAppenderHelper;
import org.apache.iceberg.data.RandomGenericData;
import org.apache.iceberg.data.Record;
-import org.apache.iceberg.flink.HadoopTableResource;
+import org.apache.iceberg.flink.HadoopTableExtension;
import org.apache.iceberg.flink.TestFixtures;
import org.apache.iceberg.flink.source.ScanContext;
import org.apache.iceberg.flink.source.StreamingStartingStrategy;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.RuleChain;
-import org.junit.rules.TemporaryFolder;
-import org.junit.rules.TestRule;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+import org.junit.jupiter.api.io.TempDir;
public class TestContinuousSplitPlannerImplStartStrategy {
private static final FileFormat FILE_FORMAT = FileFormat.PARQUET;
- public final TemporaryFolder temporaryFolder = new TemporaryFolder();
- public final HadoopTableResource tableResource =
- new HadoopTableResource(
- temporaryFolder, TestFixtures.DATABASE, TestFixtures.TABLE,
TestFixtures.SCHEMA);
- @Rule public final TestRule chain =
RuleChain.outerRule(temporaryFolder).around(tableResource);
+ @TempDir protected Path temporaryFolder;
+
+ @RegisterExtension
+ private static final HadoopTableExtension tableResource =
Review Comment:
same as in the other class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
