kevinjqliu commented on code in PR #900:
URL: https://github.com/apache/iceberg-python/pull/900#discussion_r1667536334
##########
pyiceberg/manifest.py:
##########
@@ -762,10 +762,10 @@ def add_entry(self, entry: ManifestEntry) ->
ManifestWriter:
if (
(entry.status == ManifestEntryStatus.ADDED or entry.status ==
ManifestEntryStatus.EXISTING)
- and entry.data_sequence_number is not None
- and (self._min_data_sequence_number is None or
entry.data_sequence_number < self._min_data_sequence_number)
+ and entry.sequence_number is not None
+ and (self._min_data_sequence_number is None or
entry.sequence_number < self._min_data_sequence_number)
Review Comment:
nit: there are a few variables named `min_data_sequence_number`, should we
change those to match?
https://github.com/search?q=repo%3Aapache%2Ficeberg-python%20data_sequence_number&type=code
##########
tests/utils/test_manifest.py:
##########
@@ -66,7 +66,7 @@ def test_read_manifest_entry(generated_manifest_entry_file:
str) -> None:
assert manifest_entry.status == ManifestEntryStatus.ADDED
Review Comment:
nit: add a test to check the string representation fo manifest_entry to show
that the new field is called `sequence_number`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
