nastra commented on code in PR #9905:
URL: https://github.com/apache/iceberg/pull/9905#discussion_r1669926992
##########
.palantir/revapi.yml:
##########
@@ -1018,6 +1018,13 @@ acceptedBreaks:
old: "method void
org.apache.iceberg.PositionDeletesTable.PositionDeletesBatchScan::<init>(org.apache.iceberg.Table,\
\ org.apache.iceberg.Schema, org.apache.iceberg.TableScanContext)"
justification: "Removing deprecated code"
+ org.apache.iceberg:iceberg-orc:
Review Comment:
we can't break existing APIs but you could add an overloaded version of that
method that takes an additional parameter. That way it won't break the existing
API. See also
https://iceberg.apache.org/contribute/#adding-new-functionality-without-breaking-apis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
