QuakeWang commented on code in PR #441:
URL: https://github.com/apache/iceberg-rust/pull/441#discussion_r1672302642
##########
.github/workflows/ci.yml:
##########
@@ -34,7 +34,12 @@ env:
jobs:
check:
- runs-on: ubuntu-latest
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ os:
+ - ubuntu-latest
+ - macos-latest
Review Comment:
The `skywalking-eyes` may not support Windows.
##########
.github/workflows/ci.yml:
##########
@@ -95,7 +100,12 @@ jobs:
run: cargo build -p iceberg --no-default-features
unit:
- runs-on: ubuntu-latest
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ os:
+ - ubuntu-latest
+ - macos-latest
Review Comment:
> Sorry I was wrong about the failure on macos. It seems that github
action's provided macos has no docker installation, which is relied on by our
test, so we should remove this part.
Ok, I will restore this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
