syun64 commented on code in PR #910:
URL: https://github.com/apache/iceberg-python/pull/910#discussion_r1674334862
##########
pyiceberg/table/__init__.py:
##########
@@ -528,10 +528,6 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
)
_check_schema_compatible(self._table.schema(), other_schema=df.schema)
- # cast if the two schemas are compatible but not equal
- table_arrow_schema = self._table.schema().as_arrow()
- if table_arrow_schema != df.schema:
- df = df.cast(table_arrow_schema)
Review Comment:
Removed this cast function - `to_requested_schema` should be responsible for
casting the types to their desired schema, instead of casting it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
