findepi commented on code in PR #10691:
URL: https://github.com/apache/iceberg/pull/10691#discussion_r1675927724
##########
core/src/main/java/org/apache/iceberg/util/ParallelIterable.java:
##########
@@ -88,7 +91,18 @@ private ParallelIterator(
@Override
public void close() {
// close first, avoid new task submit
- this.closed = true;
+ this.closed.set(true);
+
+ for (Task<T> task : yieldedTasks) {
+ try {
+ task.close();
+ } catch (Exception e) {
+ throw new RuntimeException("Close failed", e);
+ }
+ }
+ yieldedTasks.clear();
+
+ // TODO close input iterables that were not started yet
Review Comment:
This is preexisting problem and easy to fix. Let's fix as a follow-up to
keep the PRs easy to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
