rdblue commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1676512526
##########
.palantir/revapi.yml:
##########
@@ -1018,6 +1018,17 @@ acceptedBreaks:
old: "method void
org.apache.iceberg.PositionDeletesTable.PositionDeletesBatchScan::<init>(org.apache.iceberg.Table,\
\ org.apache.iceberg.Schema, org.apache.iceberg.TableScanContext)"
justification: "Removing deprecated code"
+ "1.5.0":
+ org.apache.iceberg:iceberg-api:
+ - code: "java.class.defaultSerializationChanged"
+ old: "class org.apache.iceberg.encryption.EncryptingFileIO"
+ new: "class org.apache.iceberg.encryption.EncryptingFileIO"
+ justification: "Decrypting input mist receive length"
+ - code: "java.method.removed"
+ old: "method org.apache.iceberg.io.InputFile
org.apache.iceberg.encryption.EncryptingFileIO::newDecryptingInputFile(java.lang.String,\
+ \ java.nio.ByteBuffer)"
Review Comment:
I agree that we want to remove this, but we can't make changes to API like
this until a new major release. Can you please deprecate the method instead and
make a note that it will be removed in 2.0.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
