rdblue commented on code in PR #7770: URL: https://github.com/apache/iceberg/pull/7770#discussion_r1676567628
########## core/src/main/java/org/apache/iceberg/SnapshotParser.java: ########## @@ -155,7 +213,11 @@ static Snapshot fromJson(JsonNode node) { operation, summary, schemaId, - manifestList); + manifestList, + manifestListSize, + manifestListKeyMetadata, + wrappedManifestListKeyMetadata, + wrappedKeyEncryptionKey); Review Comment: This should create the `ManifestListFile` and pass it in rather than relying on `Snapshot` to create it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org