rdblue commented on code in PR #10691:
URL: https://github.com/apache/iceberg/pull/10691#discussion_r1677181134
##########
core/src/main/java/org/apache/iceberg/util/ParallelIterable.java:
##########
@@ -192,4 +209,65 @@ public synchronized T next() {
return queue.poll();
}
}
+
+ private static class Task<T> implements Callable<Optional<Task<T>>>,
Closeable {
+ private final Iterable<T> input;
+ private final ConcurrentLinkedQueue<T> queue;
+ private final AtomicBoolean closed;
+ private final int approximateMaxQueueSize;
+
+ private Iterator<T> iterator;
+
+ Task(
+ Iterable<T> input,
+ ConcurrentLinkedQueue<T> queue,
+ AtomicBoolean closed,
+ int approximateMaxQueueSize) {
+ this.input = Preconditions.checkNotNull(input, "input cannot be null");
+ this.queue = Preconditions.checkNotNull(queue, "queue cannot be null");
+ this.closed = Preconditions.checkNotNull(closed, "closed cannot be
null");
+ this.approximateMaxQueueSize = approximateMaxQueueSize;
+ }
+
+ @Override
+ public Optional<Task<T>> call() throws Exception {
+ try {
+ if (iterator == null) {
+ iterator = input.iterator();
+ }
+ while (iterator.hasNext()) {
+ if (queue.size() >= approximateMaxQueueSize) {
+ // yield
+ return Optional.of(this);
+ }
+ T next = iterator.next();
+ if (closed.get()) {
+ break;
+ }
+ queue.add(next);
+ }
+ } catch (Throwable e) {
+ try {
+ close();
+ } catch (IOException closeException) {
+ // self-suppression is not permitted
+ // (e and closeException to be the same is unlikely, but possible)
+ if (closeException != e) {
+ e.addSuppressed(closeException);
+ }
+ }
+ throw e;
+ }
+ close();
+ return Optional.empty();
Review Comment:
Can you add a comment indicating that this task is complete and does not
need to be resubmitted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
