findepi commented on code in PR #10691:
URL: https://github.com/apache/iceberg/pull/10691#discussion_r1678930650
##########
core/src/test/java/org/apache/iceberg/util/TestParallelIterable.java:
##########
@@ -133,6 +140,47 @@ public CloseableIterator<Integer> iterator() {
.untilAsserted(() -> assertThat(queue).as("Queue is not empty after
cleaning").isEmpty());
}
+ @Test
+ public void limitQueueSize() throws IOException, IllegalAccessException,
NoSuchFieldException {
Review Comment:
Do you have any particular benchmark in mind?
I though that maybe `ManifestReadBenchmark` or `PlanningBenchmark` would be
useful, but they don't seem to be. (my verification method: i planted an
exception in the parallel iterator task code, but benchmarks still run)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
