snazy commented on PR #10711:
URL: https://github.com/apache/iceberg/pull/10711#issuecomment-2238528235
WDYT of adding the function directly to `FileIO` as a `default` function:
```java
public interface FileIO extends Serializable, Closeable {
boolean recoverFile(String path) {
return false;
}
}
```
All (major) `FileIO` implementations implement all mixins/extensions.
Unrelated to this PR, I think it would be easier to have just `FileIO` with
default implementations - otherwise we end up in situations where the actual
backend impl (e.g. `S3FileIO` "looses" functionality, because the
wrapper/delegate (think `EncryptingFileIO`) does not properly implement "all
the interfaces". And if the wrapper/delegate has to implement all the
interfaces, there's maybe no point in having distinct interfaces?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
