amogh-jahagirdar commented on code in PR #10352:
URL: https://github.com/apache/iceberg/pull/10352#discussion_r1684453312


##########
core/src/main/java/org/apache/iceberg/SchemaUpdate.java:
##########
@@ -533,6 +537,34 @@ private static Schema applyChanges(
       }
     }
 
+    Map<Integer, List<Integer>> specToDeletes = Maps.newHashMap();

Review Comment:
   @advancedxy That's reasonable, we can do the 2 independently. Cool, 
discussed offline with @RussellSpitzer feel free to go for it, for carrying 
forward the removing historical partitions PR! 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to