rdblue commented on a change in pull request #1213:
URL: https://github.com/apache/iceberg/pull/1213#discussion_r460583043
##########
File path: core/src/main/java/org/apache/iceberg/io/PartitionedWriter.java
##########
@@ -63,10 +66,29 @@ public void write(InternalRow row) throws IOException {
throw new IllegalStateException("Already closed files for partition: "
+ key.toPath());
}
- setCurrentKey(key.copy());
- openCurrent();
+ currentKey = key.copy();
+ }
+
+ if (currentAppender == null) {
+ currentAppender = new RollingFileAppender(currentKey);
Review comment:
It would be nice to not change the logic for opening an appender.
Before, this was part of the flow of changing partitions and I don't see any
value in moving it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
