syun64 commented on code in PR #951:
URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1686558332
##########
pyproject.toml:
##########
@@ -61,7 +61,10 @@ tenacity = ">=8.2.3,<9.0.0"
pyarrow = { version = ">=9.0.0,<18.0.0", optional = true }
pandas = { version = ">=1.0.0,<3.0.0", optional = true }
duckdb = { version = ">=0.5.0,<2.0.0", optional = true }
-ray = { version = ">=2.0.0,<2.10.0", optional = true }
+ray = [
+ { version = "==2.10.0", python = "<3.9", optional = true},
+ { version = ">=2.10.0,<3.0.0", python = ">=3.9", optional = true}
+]
Review Comment:
That makes sense @Fokko - thank you for all these notes. Learning a lot this
time around during this release :)
My hope is that we can do away with this python version based override once
we remove support for python3.8 to keep this simple again. But in a world where
our dependencies deploy binaries for only a subset of the versions, I think
this practices is unfortunately unavoidable - unless we want to aggressively
drop support for lower python versions as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
