soumya-ghosh commented on code in PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#discussion_r1689346998
##########
tests/table/test_init.py:
##########
@@ -689,7 +689,7 @@ def test_update_metadata_add_snapshot(table_v2: Table) ->
None:
snapshot_id=25,
parent_snapshot_id=19,
sequence_number=200,
- timestamp_ms=1602638573590,
+ timestamp_ms=1602638593590,
Review Comment:
This change is relevant now, I missed to update his comment.
Basically I'm keeping the timestamp of snapshot to be higher than
last-updated-ms of the table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
