jqin61 commented on code in PR #955:
URL: https://github.com/apache/iceberg-python/pull/955#discussion_r1690408866
##########
tests/integration/test_deletes.py:
##########
@@ -417,3 +452,107 @@ def test_delete_truncate(session_catalog: RestCatalog) ->
None:
assert len(entries) == 1
assert entries[0].status == ManifestEntryStatus.DELETED
+
+
[email protected]
+def test_delete_overwrite_table_with_null(session_catalog: RestCatalog) ->
None:
+ arrow_schema = pa.schema([pa.field("ints", pa.int32())])
+ arrow_tbl = pa.Table.from_pylist(
+ [{"ints": 1}, {"ints": 2}, {"ints": None}],
+ schema=arrow_schema,
+ )
+
+ iceberg_schema = Schema(NestedField(1, "ints", IntegerType()))
+
+ tbl_identifier = "default.test_delete_overwrite_with_null"
+
+ try:
+ session_catalog.drop_table(tbl_identifier)
+ except NoSuchTableError:
+ pass
+
+ tbl = session_catalog.create_table(tbl_identifier, iceberg_schema)
+ tbl.append(arrow_tbl)
Review Comment:
sounds good! let's put it in a future pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
