Fokko commented on code in PR #962: URL: https://github.com/apache/iceberg-python/pull/962#discussion_r1690921688
########## pyiceberg/catalog/rest.py: ########## @@ -118,7 +120,8 @@ class Endpoints: SIGV4 = "rest.sigv4-enabled" SIGV4_REGION = "rest.signing-region" SIGV4_SERVICE = "rest.signing-name" -AUTH_URL = "rest.authorization-url" +DEPRECATED_AUTH_URL = "rest.authorization-url" Review Comment: I would suggest to remove this together with the deprecation. ```suggestion AUTH_URL = "rest.authorization-url" ``` If people are using this like in the `test_rest.py`, it will break their code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
