fqaiser94 commented on code in PR #481:
URL: https://github.com/apache/iceberg-rust/pull/481#discussion_r1691486557
##########
crates/iceberg/src/io/storage.rs:
##########
@@ -79,6 +87,16 @@ impl Storage {
) -> crate::Result<(Operator, &'a str)> {
let path = path.as_ref();
match self {
+ #[cfg(feature = "storage-memory")]
+ Storage::Memory { config } => {
+ let op = config.build(path)?;
+
+ if let Some(stripped) = path.strip_prefix("file:/") {
+ Ok((op, stripped))
Review Comment:
nit: I don't personally think that stripping `file:/` is necessary.
If users want to use file-system like naming inside memory-storage, I would
just let them 🤷
Otherwise, you could argue that you should also strip things like `s3:/` as
well 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
