chinmay-bhat commented on code in PR #950:
URL: https://github.com/apache/iceberg-python/pull/950#discussion_r1694696015
##########
pyiceberg/table/__init__.py:
##########
@@ -1129,12 +1128,22 @@ def _(update: SetSnapshotRefUpdate, base_metadata:
TableMetadata, context: _Tabl
return base_metadata.model_copy(update=metadata_updates)
+@_apply_table_update.register(RemoveSnapshotRefUpdate)
+def _(update: RemoveSnapshotRefUpdate, base_metadata: TableMetadata, context:
_TableMetadataUpdateContext) -> TableMetadata:
Review Comment:
I think that would helpful! In case a feature is not implemented, like
`RemoveSnapshotRefUpdate` and `RemoveSnapshotsUpdate`, the test should atleast
print a message saying so.
It would help keep track of which features are / are not implemented, and
won't be surprise to the end user or us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
