alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695526821


##########
crates/catalog/rest/testdata/rest_catalog/docker-compose.yaml:
##########
@@ -15,6 +15,9 @@
 # specific language governing permissions and limitations
 # under the License.
 
+networks:

Review Comment:
   The docker docs warn that "links" keyword is legacy and should be replaced 
with "networks" when possible. Docs also say "networks" keyword along with 
"aliases" is preferred way for doing "links" like behavior. For podman v4, 
"links" is entirely not supported.
   https://docs.docker.com/network/links



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to