alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695784200
##########
crates/test_utils/src/cmd.rs:
##########
@@ -28,6 +28,17 @@ pub fn run_command(mut cmd: Command, desc: impl ToString) {
}
}
+pub fn get_cmd_output_dont_panic(mut cmd: Command, desc: impl ToString) ->
Result<String, String> {
+ let desc = desc.to_string();
+ log::info!("Starting to {}, command: {:?}", &desc, cmd);
+ let output = cmd.output().unwrap();
+ if output.status.success() {
+ Ok(String::from_utf8(output.stdout).unwrap())
+ } else {
+ Err(format!("{} failed: {:?}", desc, output.status))
+ }
+}
+
Review Comment:
Fixed,
https://github.com/apache/iceberg-rust/pull/489/commits/4d34a0dcf61850080ae095748bdae460aa2aaf41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
