ndrluis commented on code in PR #988:
URL: https://github.com/apache/iceberg-python/pull/988#discussion_r1700166156
##########
pyiceberg/expressions/literals.py:
##########
@@ -588,7 +589,7 @@ def _(self, type_var: DecimalType) -> Literal[Decimal]:
def _(self, type_var: BooleanType) -> Literal[bool]:
value_upper = self.value.upper()
if value_upper in ["TRUE", "FALSE"]:
- return BooleanLiteral(value_upper == "TRUE")
+ return BooleanLiteral(strtobool(value_upper))
Review Comment:
Yeah, in this case, it makes sense to be strict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
