nastra commented on code in PR #10837: URL: https://github.com/apache/iceberg/pull/10837#discussion_r1700227905
########## core/src/test/java/org/apache/iceberg/rest/RESTCatalogServlet.java: ########## @@ -20,6 +20,9 @@ import static java.lang.String.format; +import jakarta.servlet.http.HttpServlet; Review Comment: fyi I tried to do the same for the `S3SignerServlet` in `iceberg-aws` but that isn't currently working because `iceberg-aws` pulls in https://github.com/apache/iceberg/blob/b0cf9988c9d837c03aacc4fe9d45058b63fb68fd/build.gradle#L505 which in turn pulls in a different Jetty version. Updating the s3mock isn't possible atm because a newer version depends on JDK17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
