leangjonathan commented on code in PR #10861:
URL: https://github.com/apache/iceberg/pull/10861#discussion_r1710029012
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1020,8 +1020,11 @@ public Builder upgradeFormatVersion(int
newFormatVersion) {
return this;
}
- this.formatVersion = newFormatVersion;
- changes.add(new MetadataUpdate.UpgradeFormatVersion(newFormatVersion));
+ // register incremental version changes separately to ensure all upgrade
requirements are met.
+ // formatVersion will be equivalent to newFormatVersion after the loop
completes
+ do {
Review Comment:
I can set it back to the original loop logic then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
