nastra commented on code in PR #10877:
URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710798023
##########
core/src/main/java/org/apache/iceberg/rest/RESTUtil.java:
##########
@@ -215,8 +232,33 @@ public static String encodeNamespace(Namespace ns) {
* @return a namespace
*/
public static Namespace decodeNamespace(String encodedNs) {
- Preconditions.checkArgument(encodedNs != null, "Invalid namespace: null");
- String[] levels =
Iterables.toArray(NAMESPACE_ESCAPED_SPLITTER.split(encodedNs), String.class);
+ return decodeNamespace(encodedNs, NAMESPACE_ESCAPED_SEPARATOR);
+ }
+
+ /**
+ * Takes in a string representation of a namespace as used for a URL
parameter and returns the
+ * corresponding namespace.
+ *
+ * <p>See also {@link #encodeNamespace} for generating correctly formatted
URLs.
+ *
+ * @param encodedNamespace a namespace to decode
+ * @param namespaceSeparator The namespace separator to use for decoding.
This should be the same
+ * separator that was used when calling {@link
RESTUtil#encodeNamespace(Namespace, String)}
+ * @return a namespace
+ */
+ public static Namespace decodeNamespace(String encodedNamespace, String
namespaceSeparator) {
+ Preconditions.checkArgument(encodedNamespace != null, "Invalid namespace:
null");
+ Preconditions.checkArgument(
+ !Strings.isNullOrEmpty(namespaceSeparator), "Invalid namespace
separator: null or empty");
+ String[] levels;
+
+ // for backwards compatibility
Review Comment:
it would be still necessary to be compatible with an old client that doesn't
send send the query param and doesn't respect the new
`rest-namespace-separator` that the server sends. There's also a specific test
that verifies this scenario in
`TestRestUtil.encodeAsOldClientAndDecodeAsNewServer()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
