openinx commented on pull request #1145: URL: https://github.com/apache/iceberg/pull/1145#issuecomment-668012934
Ping @rdblue @JingsongLi @kbendick , Mind to take another look if you have time ? Thanks. Some background: as we have discussed in the [issue](https://github.com/apache/iceberg/issues/1215#issuecomment-661994888) that flink-iceberg will use `RowData` as its internal data type for readers and writers, so in theory we should provide a `TaskWriterFactory<Rowdata>` (instead of `TaskWriterFactory<Row>`) to create the `TaskWriter<RowData>` and write `RowData` records. But now we don't have any available `RowData` readers and writers, so we could only write unit test based on `TaskWriter<Row>`. In future, Once the `RowData` parquet/avro/orc reader/writers are available, I will change the `RowTaskWriterFactory` to `RowDataTaskWriterFactory` , also the unit test (that's should be easy to do). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
