kevinjqliu commented on code in PR #1055:
URL: https://github.com/apache/iceberg-python/pull/1055#discussion_r1716150796
##########
tests/integration/test_reads.py:
##########
@@ -753,6 +753,7 @@ def test_configure_row_group_batch_size(session_catalog:
Catalog) -> None:
assert len(batches) == entries
[email protected]
Review Comment:
Does CI fail if we don't add this line? It's what we're testing for in #1051
##########
Makefile:
##########
@@ -67,7 +70,10 @@ test-coverage:
sleep 10
docker compose -f dev/docker-compose-integration.yml cp
./dev/provision.py spark-iceberg:/opt/spark/provision.py
docker compose -f dev/docker-compose-integration.yml exec -T
spark-iceberg ipython ./provision.py
- poetry run coverage run --source=pyiceberg/ -m pytest tests/
${PYTEST_ARGS}
+ poetry run coverage run --data-file=.coverage.integration
--source=pyiceberg/ -m pytest tests/ -m integration ${PYTEST_ARGS}
Review Comment:
nit: to match the other command, also added `-v` to match `test-integration`
```suggestion
poetry run coverage run --source=pyiceberg/
--data-file=.coverage.integration -m pytest tests/ -v -m integration
${PYTEST_ARGS}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
