nastra commented on PR #10938:
URL: https://github.com/apache/iceberg/pull/10938#issuecomment-2290924253

   please also apply
   ```
   --- a/baseline.gradle
   +++ b/baseline.gradle
   @@ -91,16 +91,14 @@ subprojects {
              '-Xep:CollectionUndefinedEquality:ERROR',
              // specific to Palantir - Uses name `log` but we use name `LOG`
              '-Xep:ConsistentLoggerName:OFF',
   -          // TODO (https://github.com/apache/iceberg/issues/10853) this is 
a recently added check. Figure out whether we adjust the code or suppress for 
good
   -          '-Xep:DangerousJavaDeserialization:WARN',
   +          '-Xep:DangerousJavaDeserialization:ERROR',
              '-Xep:DangerousThreadPoolExecutorUsage:OFF',
              // subclasses are not equal
              '-Xep:EqualsGetClass:OFF',
              // specific to Palantir
              '-Xep:FinalClass:OFF',
              '-Xep:FormatStringAnnotation:ERROR',
   -          // TODO (https://github.com/apache/iceberg/issues/10855) this is 
a recently added check. Figure out whether we adjust the code or suppress for 
good
   -          '-Xep:ImmutablesReferenceEquality:WARN',
   +          '-Xep:ImmutablesReferenceEquality:ERROR',
              '-Xep:IntLongMath:ERROR',
              // prefer method references over lambdas
              '-Xep:LambdaMethodReference:ERROR',
   ```
   so that we're now erroring out in case this comes up again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to