nastra commented on code in PR #10872:
URL: https://github.com/apache/iceberg/pull/10872#discussion_r1718219721
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -174,7 +176,7 @@ DelegateFileIO io(String location) {
return ioInstances.computeIfAbsent(
impl,
key -> {
- Configuration conf = hadoopConf.get();
+ Configuration conf =
Optional.ofNullable(hadoopConf).map(Supplier::get).orElse(null);
Review Comment:
given that `ResolvingFileIO` is implementing `Configurable` from Hadoop it
actually requires the conf to be set via `setConf` but I agree that this is a
bit problematic for FileIO instances that don't need this, like `S3FileIO`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
