guitcastro commented on code in PR #1033:
URL: https://github.com/apache/iceberg-python/pull/1033#discussion_r1723770469
##########
pyiceberg/catalog/rest.py:
##########
@@ -532,7 +534,7 @@ def _config_headers(self, session: Session) -> None:
session.headers["Content-type"] = "application/json"
session.headers["X-Client-Version"] = ICEBERG_REST_SPEC_VERSION
session.headers["User-Agent"] = f"PyIceberg/{__version__}"
- session.headers["X-Iceberg-Access-Delegation"] = "vended-credentials"
+ session.headers["X-Iceberg-Access-Delegation"] =
self.properties.get(ACCESS_DELEGATION, ACCESS_DELEGATION_DEFAULT)
Review Comment:
IMHO having an explicit and documented property is better than setting
custom header. But I can change if you think it's better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
