rdblue commented on code in PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#discussion_r1729552330
##########
api/src/main/java/org/apache/iceberg/util/DateTimeUtil.java:
##########
@@ -124,6 +135,11 @@ public static long isoTimestamptzToMicros(String
timestampString) {
OffsetDateTime.parse(timestampString,
DateTimeFormatter.ISO_DATE_TIME));
}
+ public static long isoTimestampToNanos(CharSequence timestamp) {
+ return ChronoUnit.NANOS.between(
+ EPOCH, OffsetDateTime.parse(timestamp,
DateTimeFormatter.ISO_DATE_TIME));
Review Comment:
Looks like this uses `ISO_DATE_TIME` format and `OffsetDateTime`, which
allows a time zone offset and corresponds to `timestamptz` (see the micros
equivalent immediately above). This should actually be `isoTimestamptzToNanos`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
