amogh-jahagirdar commented on code in PR #11044: URL: https://github.com/apache/iceberg/pull/11044#discussion_r1737002471
########## core/src/main/java/org/apache/iceberg/InheritableMetadataFactory.java: ########## @@ -46,11 +49,14 @@ static class BaseInheritableMetadata implements InheritableMetadata { private final int specId; private final long snapshotId; private final long sequenceNumber; + private final String manifestPath; - private BaseInheritableMetadata(int specId, long snapshotId, long sequenceNumber) { + private BaseInheritableMetadata( + int specId, long snapshotId, long sequenceNumber, String manifestPath) { Review Comment: Passing through the manifest path through inheritable metadata similar to sequence numbers seemed like the cleanest way -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org