a-agmon commented on PR #588:
URL: https://github.com/apache/iceberg-rust/pull/588#issuecomment-2323262045
Hey @sdd, @FANNG1 and @liurenjie1024
Please see updated PR. I have refactored `predicate_converter` into a
separate module that follows a more visitor-ish approach.
The `scan` mod is now clean and convert predicates using:
```rust
fn convert_filters_to_predicate(filters: &[Expr]) -> Option<Predicate> {
PredicateConverter.visit_many(filters)
}
```
`PredicateConverter` is now more modular and allows adding more expressions
and patterns. Though I think that it currently covers quite a lot of the cases
that are commonly supported in pushdown strategies. Most of the complexity is
just in identifying and matching the particular patterns of the `Expr` we need
to deal with in different ways.
Please let me know what do you think about this
also note that I have added a fix to the schema mod that correctly converts
Date type to its Arrow type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
