hantangwangd commented on code in PR #10983:
URL: https://github.com/apache/iceberg/pull/10983#discussion_r1739706862
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -370,7 +370,7 @@ public void testRetainLastWithExpireById() {
}
// Retain last 3 snapshots, but explicitly remove the first snapshot
-
removeSnapshots(table).expireSnapshotId(firstSnapshotId).retainLast(3).commit();
+
table.expireSnapshots().expireSnapshotId(firstSnapshotId).retainLast(3).commit();
Review Comment:
Thank you very much for this explanation. Yes, this change chooses a more
safer strategy when expiring snapshots through specifying snapshot IDs, so
users will not fall into the dangerous state described above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
